Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diego/ora-1452 ORA-1455 stress tests fix nonces error #289

Merged
merged 14 commits into from
May 22, 2024

Conversation

xmariachi
Copy link
Contributor

@xmariachi xmariachi commented May 22, 2024

Sorting of maps is nondeterministic. Hence it was placing the sequence of pseudorandom numbers in wrong order.
Sorting the keys in advance ensures a deterministic map iteration.

xmariachi and others added 8 commits May 20, 2024 13:59
…rs, or topics (#280)

Allow any number of reputers, workers, and topics to be specified. The
target for this pr is Diego's stress testing pr. Additional topics are
run in a subroutine, and this pr attempts to handle all potential
concurrency issues.

Example command: 

`bash local_testnet_l1.sh ; STRESS_TEST=true REPUTERS_PER_EPOCH=1
WORKERS_PER_EPOCH=1 TOPICS_PER_EPOCH=1 go test -v -timeout 0 -test.run
TestStressTestSuite .`

---------

Co-authored-by: Diego C <xmariachi@gmail.com>
@xmariachi xmariachi changed the title Diego/ora 1452 stress tests fix nonces error Diego/ora-1452 ORA-1455 stress tests fix nonces error May 22, 2024
Copy link
Collaborator

@kpeluso kpeluso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing!

You sure we wanna keep all these print statements?

Copy link
Contributor

@relyt29 relyt29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much work for so little lines of code changed 😭

@xmariachi
Copy link
Contributor Author

Great sleuthing!

You sure we wanna keep all these print statements?

Ty! I suggest keeping them for devnet/edgenet, removing most if not all in testnet.
However I'll remove some more now, leaving more meaningful logs.

@relyt29 relyt29 merged commit 14cffd8 into major-upgrade May 22, 2024
7 checks passed
@relyt29 relyt29 deleted the diego/ora-1452-stress-tests-fix-nonces-error branch May 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants