-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diego/ora-1452 ORA-1455 stress tests fix nonces error #289
Diego/ora-1452 ORA-1455 stress tests fix nonces error #289
Conversation
…rs, or topics (#280) Allow any number of reputers, workers, and topics to be specified. The target for this pr is Diego's stress testing pr. Additional topics are run in a subroutine, and this pr attempts to handle all potential concurrency issues. Example command: `bash local_testnet_l1.sh ; STRESS_TEST=true REPUTERS_PER_EPOCH=1 WORKERS_PER_EPOCH=1 TOPICS_PER_EPOCH=1 go test -v -timeout 0 -test.run TestStressTestSuite .` --------- Co-authored-by: Diego C <xmariachi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great sleuthing!
You sure we wanna keep all these print statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so much work for so little lines of code changed 😭
Ty! I suggest keeping them for devnet/edgenet, removing most if not all in testnet. |
…:allora-network/allora-chain into diego/ora-1452-stress-tests-fix-nonces-error
Sorting of maps is nondeterministic. Hence it was placing the sequence of pseudorandom numbers in wrong order.
Sorting the keys in advance ensures a deterministic map iteration.